Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-7419 - fix phone numbers - confirm individual #991

Merged
merged 6 commits into from
Aug 6, 2024
Merged

MPDX-7419 - fix phone numbers - confirm individual #991

merged 6 commits into from
Aug 6, 2024

Conversation

wjames111
Copy link
Contributor

@wjames111 wjames111 commented Aug 2, 2024 •
edited
Loading

Description

  • Tools - Fix Phone Numbers - Implement Confirm Individual
  • Jira Ticket #7419
  • Add mutation for updating Individual contacts
  • Hide individual contact once updated
  • Add test for confirm button and hiding contact

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 self-assigned this Aug 2, 2024
@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Preview branch generated at https://MPDX-7419-confirm-individual.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Bundle sizes [mpdx-react]

Compared against 63b1170

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/fixPhoneNumbers/[[...contactId]] 112.61 KB +1.5 KB

@wjames111 wjames111 requested a review from caleballdrin August 2, 2024 16:39
caleballdrin
caleballdrin requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work man! I tested it and it seems to work great. It modifies the cache and updates the phone number. I just have a small request to add a test that it calls the mock function.

src/components/Tool/FixPhoneNumbers/Contact.test.tsx
@@ -118,6 +123,7 @@ describe('FixPhoneNumbers-Contact', () => {
handleAdd={handleAddMock}
handleChangePrimary={handleChangePrimaryMock}
setContactFocus={setContactFocus}
handleUpdate={updatePhoneNumber}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could test that this mock function gets called in thisshould call mock functions test block.

Copy link
Contributor Author

@wjames111 wjames111 Aug 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'll add that test in. Let me know if I missed any other things I should test for.

@wjames111 wjames111 changed the title MPDX-7419-confirm-individual MPDX-7419 - fix phone numbers - confirm individual Aug 5, 2024
@wjames111 wjames111 requested a review from caleballdrin August 5, 2024 19:11
caleballdrin
caleballdrin approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wjames111 wjames111 merged commit bc61be7 into main Aug 6, 2024
17 of 18 checks passed
@wjames111 wjames111 deleted the MPDX-7419-confirm-individual branch August 6, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleballdrin caleballdrin caleballdrin approved these changes

Assignees

@wjames111 wjames111

Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjames111 @caleballdrin