MPDX-7417 - fix phone numbers - confirm all #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjames111
added
question
|
Preview branch generated at https://MPDX-7417-confirm-all.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against e4b7269 No significant changes found |
|
It looks like the updatePeople mutation doesn't allow for updating a phone number's source. However the confirm all button specifies updating it's source. Wondering if I'm missing something here or if the Schema needs to be updated to allow this attribute to be edited. 
|
|
The logic for the source is a bit counter-intuitive. It doesn't change the source, it uses the source to determine which to set to primary in a bulk save scenario. Selecting primary on individual items only works for the single confirm. I ran into the same when dealing with emails. You can find the logic here |
wjames111
changed the title
caleballdrin
approved these changes
Aug 6, 2024
wjames111
removed
the
Waiting on another PR
wjames111
force-pushed
the
MPDX-7417-confirm-all
branch
from
c85e483 to
07b5449
Compare
wjames111
commented
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: