Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-7421 - fix phone numbers - Infinite list #993

Closed
wants to merge 4 commits into from
Closed

MPDX-7421 - fix phone numbers - Infinite list #993

wants to merge 4 commits into from

Conversation

wjames111
Copy link
Contributor

Description

  • Convert to infinite list like the contacts/tasks page
  • Jira ticket #7421

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 self-assigned this Aug 5, 2024
@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Preview branch generated at https://MPDX-7421-add-pagination.d3dytjb8adxkk5.amplifyapp.com

@wjames111 wjames111 requested a review from dr-bizz August 5, 2024 16:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 70b550e

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/fixPhoneNumbers/[[...contactId]] 131.61 KB +18.9 KB

@wjames111 wjames111 changed the title MPDX-7421-Infinite-list MPDX-7421 - fix phone numbers - Infinite list Aug 5, 2024
@dr-bizz dr-bizz requested review from caleballdrin and removed request for dr-bizz August 7, 2024 18:33
caleballdrin
caleballdrin reviewed Aug 8, 2024
View reviewed changes
src/components/Tool/FixPhoneNumbers/FixPhoneNumbers.tsx Outdated
variables: { after: data.people.pageInfo.endCursor },
})
}
EmptyPlaceholder={<NoData tool="fixEmailAddresses" />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the NoData to fixPhoneNumbers

@caleballdrin
Copy link
Contributor

@wjames111 it looks like this is also reloading when you scroll down and it loads more items. I wonder if we need a useMemo or useEffect somewhere.

@wjames111
Copy link
Contributor Author

@caleballdrin Isn't it going to need to rerender regardless when fetchMore is called? Not really sure how the InfiniteList works to be honest.

@wjames111 wjames111 closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleballdrin caleballdrin caleballdrin left review comments

Assignees

@wjames111 wjames111

Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjames111 @caleballdrin