Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-0000 - fix phone numbers - style updates #994

Merged
merged 15 commits into from
Aug 13, 2024
Merged

MPDX-0000 - fix phone numbers - style updates #994

merged 15 commits into from
Aug 13, 2024

Conversation

wjames111
Copy link
Contributor

@wjames111 wjames111 commented Aug 5, 2024 •
edited
Loading

Description

  • No ticket for this
  • Style updates to Fix Phone Numbers

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 changed the title MPDX-0000-style-updates-fix-phone-numbers MPDX-0000 - fix phone numbers - style updates Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 4207200

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/fixPhoneNumbers/[[...contactId]] 115.07 KB +2.36 KB

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Aug 7, 2024
@wjames111 wjames111 self-assigned this Aug 7, 2024
@wjames111 wjames111 requested a review from caleballdrin August 8, 2024 21:32
@caleballdrin caleballdrin added Preview Environment Add this label to create an Amplify Preview and removed Preview Environment Add this label to create an Amplify Preview labels Aug 13, 2024
@caleballdrin caleballdrin self-requested a review August 13, 2024 02:23
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-0000-style-updates.d3dytjb8adxkk5.amplifyapp.com

@caleballdrin caleballdrin self-requested a review August 13, 2024 02:31
caleballdrin
caleballdrin approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix that one issue with the button and then this looks good to go. Great work on it!

@wjames111 wjames111 merged commit bbc74f4 into main Aug 13, 2024
17 of 18 checks passed
@wjames111 wjames111 deleted the MPDX-0000-style-updates branch August 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleballdrin caleballdrin caleballdrin approved these changes

Assignees

@wjames111 wjames111

Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjames111 @caleballdrin