Making scrunch compatible with Python 3.11 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @shaikh-ma! |
|
Hi @jjdelc, As discussed, here's the Pull Request which supports 3.6 & 3.11. Please could verify it on your end and let us know if it's good to be merged. :) |
|
Hi @jjdelc, Can you please let us know how/when this PR can progress? This is a significant impediment to our efforts to update our code base at the moment. If there is anything we can do to further help resolve the PR, please just let us know. Cheers, |
|
I'll look at this now |
|
Thanks @shaikh-ma !! |
|
Thank you too @jjdelc !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the issues section of the
scrunchrepository here, this Pull Request attempts to makescrunchcompatible with the Python version3.11.The adjustments are made only in the modules,
dataset.py,order.py&expressions.py.These include version specific checks for importing methods from the
collectionmodule and accessing of values of theast.Subscriptobject.