Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix float cast to int/id in expressions #456

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix float cast to int/id in expressions #456

merged 2 commits into from
Jul 22, 2024

Conversation

aless10
Copy link
Contributor

@aless10 aless10 commented Jun 19, 2024

@aless10
- add is_id function that checks if a value can be cast into an int.
16e2551 
- add test on process_expr to handle expressions that has floats instead
  of integers with the `in` expression
@aless10 aless10 requested a review from jjdelc June 19, 2024 13:35
@aless10 aless10 mentioned this pull request Jul 3, 2024
Merged
@jjdelc jjdelc merged commit 08f5a3a into master Jul 22, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjdelc jjdelc Awaiting requested review from jjdelc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aless10 @jjdelc