Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller-gen to v0.17.2 #4064

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Bump controller-gen to v0.17.2 #4064

merged 2 commits into from
Feb 11, 2025

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Jan 3, 2025

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Other

@cbandy

This comment was marked as resolved.

Sign in to view
@cbandy cbandy marked this pull request as draft January 3, 2025 22:36
@cbandy cbandy changed the title Bump controller-gen to v0.17.0 Bump controller-gen to v0.17.2 Feb 10, 2025
@cbandy cbandy marked this pull request as ready for review February 10, 2025 20:31
tjmoore4
tjmoore4 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@tjmoore4 tjmoore4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

📝 For others who might be reviewing, I found this blog post helpful when reviewing the changes.

pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgres_types.go Show resolved Hide resolved
@cbandy
Change PostgresIdentifier to a type alias
0b4fbd3 
The type existed to avoid schema repetition with controller-gen, but
recent versions can do that using aliases. This eliminates the need for
some conversions.
@cbandy cbandy merged commit fbb4f32 into CrunchyData:main Feb 11, 2025
18 of 19 checks passed
@cbandy cbandy deleted the bump-gen branch February 11, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjmoore4 tjmoore4 tjmoore4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbandy @tjmoore4