Ensure OTel directories are writable #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjb
reviewed
Feb 11, 2025
cbandy
force-pushed
the
otel-directories
branch
from
b393115 to
86ed388
Compare
This prevents log records from being emitted multiple times.
The `install` command only sets permissions on the final directory.
The `install` command only sets permissions on the final directory.
cbandy
force-pushed
the
otel-directories
branch
from
86ed388 to
7cdd56f
Compare
benjaminjb
reviewed
Feb 12, 2025
|
|
||
| otelConfig.Extensions["file_storage/pgadmin_data_logs"] = map[string]any{ | ||
| "directory": "/var/lib/pgadmin/logs/receiver", | ||
| "create_directory": false, |
There was a problem hiding this comment.
OK, so we're creating the /receiver directory in pod.go
shell.MakeDirectories(0o775, dataMountPath, path.Join(LogDirectoryAbsolutePath, "receiver")),
hmmm, not sure I have a question here, just interested in the different way we're doing this.
There was a problem hiding this comment.
I've put TODOs elsewhere to create the directory using our function. This create_directory option does not do what we need in Kubernetes; opentelemetry-collector-contrib#37774
IMV, this directory is a collector concern and belongs in its (the sidecar's) shell entrypoint or other init.
benjaminjb
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
The pgAdmin log offsets are stored in
/tmpto avoid conflicting permissions.What is the new behavior (if this is a feature change)?
The pgAdmin log directories are created and updated to be writable during startup. Log offsets are now stored alongside logs.