-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rank syndrome decoding estimator #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, just some smaller changes.
Why are there changes to the Mayo and MQ estimator, couldn't follow that, is it just some code reusing re-structuring?
@Javierverbel @ricardovp85 Haven't checked the formulas yet, planning to study the overleaf soon.
@Memphisd The Mayo and MQ estimator changes are related to code refactoring!
cryptographic_estimators/RSDEstimator/RSDAlgorithms/basis_enumeration.py
Outdated
Show resolved
Hide resolved
cryptographic_estimators/RSDEstimator/RSDAlgorithms/basis_enumeration.py
Outdated
Show resolved
Hide resolved
cryptographic_estimators/RSDEstimator/RSDAlgorithms/basis_enumeration.py
Outdated
Show resolved
Hide resolved
cryptographic_estimators/RSDEstimator/RSDAlgorithms/basis_enumeration.py
Outdated
Show resolved
Hide resolved
cryptographic_estimators/RSDEstimator/RSDAlgorithms/support_minors.py
Outdated
Show resolved
Hide resolved
cryptographic_estimators/RSDEstimator/RSDAlgorithms/support_minors.py
Outdated
Show resolved
Hide resolved
…or' into feature/implement_RankSD_estimator
cryptographic_estimators/RankSDEstimator/RankSDAlgorithms/basis_enumeration.py
Outdated
Show resolved
Hide resolved
cryptographic_estimators/RankSDEstimator/RankSDAlgorithms/basis_enumeration.py
Show resolved
Hide resolved
…or' into feature/implement_RankSD_estimator
# Conflicts: # README.md
…or' into feature/implement_RankSD_estimator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some minor comments it can be merged from my side.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Description
Review process
For the rank syndrome decoding estimator, the following algorithms are implemented.
Pre-approval checklist