Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rank syndrome decoding estimator #209

Merged
merged 46 commits into from
Dec 12, 2024

Conversation

ricardovp85
Copy link
Collaborator

@ricardovp85 ricardovp85 commented Nov 6, 2024

Description

  • This PR implements the rank syndrome decoding (SD) estimator

Review process

For the rank syndrome decoding estimator, the following algorithms are implemented.

  • Basis Enumeration (Combinatorial Algorithm)
  • OJ 1 (Combinatorial algorithm)
  • OJ 2 (Combinatorial algorithm)
  • GRS (Combinatorial algorithm)
  • Improved GRS (Combinatorial algorithm)
  • Guessing Enhanced GRS (Combinatorial algorithm)
  • Hybrid Linearization (Algebraic Algorithm)
  • Max Minors (Algebraic Algorithm)
  • Support Minors (Algebraic Algorithm)

Pre-approval checklist

  • The code builds clean without any errors or warnings
  • I've added/updated tests
  • I've added/updated documentation if needed

Copy link
Collaborator

@Memphisd Memphisd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, just some smaller changes.
Why are there changes to the Mayo and MQ estimator, couldn't follow that, is it just some code reusing re-structuring?

@Javierverbel @ricardovp85 Haven't checked the formulas yet, planning to study the overleaf soon.

@Memphisd The Mayo and MQ estimator changes are related to code refactoring!

@Javierverbel
Copy link
Collaborator

The doc format should be

"""Construct an instance of RankSDEstimator.

So the doc is generated as
image

Instead of

"""
       Construct an instance of RankSDEstimator.

where we get
image

@Javierverbel Javierverbel self-requested a review December 8, 2024 13:15
Javierverbel
Javierverbel previously approved these changes Dec 8, 2024
Copy link
Collaborator

@Javierverbel Javierverbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some minor comments it can be merged from my side.

cryptographic_estimators/helper.py Outdated Show resolved Hide resolved
@Javierverbel Javierverbel self-requested a review December 9, 2024 05:41
Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link
Collaborator

@Memphisd Memphisd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Javierverbel Javierverbel merged commit 9382ea3 into develop Dec 12, 2024
6 checks passed
@Javierverbel Javierverbel deleted the feature/implement_RankSD_estimator branch December 12, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants