Performance tests #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…performance tests.
# Conflicts: # tests/unit/ciphers/permutations/salsa_permutation_test.py
…nds in test_find_lowest_weight_xor_differential_trail_with_speck_cipher; remove test_find_lowest_weight_xor_differential_trail_with_aes_cipher;
…an actions. Change run-benchmark-tests to not save the results files in the repository. Change run-benchmark-tests to run in develop and main pull requests.
peacker
reviewed
Jun 28, 2023
tests/benchmark/cipher_test.py
Outdated
| benchmark(aes.evaluate_vectorized, cipher_input) | ||
|
|
||
|
|
||
| # @pytest.mark.parametrize("number_of_samples", [10, 100, 1000, 10000]) |
There was a problem hiding this comment.
If I understood correctly, this tests were not the bottleneck in the end, so we could keep them. Please let me know if this is the case @AnaCaceres , @mariags803 , @yessica-rd .
…thods in cipher_test.py
…d aes in cipher_test.py
|
Kudos, SonarCloud Quality Gate passed! |
peacker
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.