Skip to content

Commit

Permalink
MGMT-15878: Add a condition to show the last preparation failure (ope…
Browse files Browse the repository at this point in the history
…nshift#5524)

Presently when installing a cluster, there is no indication of the reason for the last failure in preparation.
We record the fact that a failure occurred in that database field `cluster.installation_preparation_completion_status` but we do not store any
reason for the failure.

We are adding the field `cluster.installation_preparation_completion_status_reason` so that we may record the reason at the same time an
event is generated.

The content of `cluster.installation_preparation_completion_status` and `cluster.installation_preparation_completion_status_reason` are used to
determine the state of a newly created condition `LastInstallationPreparationFailed`
  • Loading branch information
paul-maidment authored Nov 6, 2023
1 parent 5f7f3f1 commit ea87037
Show file tree
Hide file tree
Showing 31 changed files with 941 additions and 57 deletions.
5 changes: 5 additions & 0 deletions api/hiveextension/v1beta1/agentclusterinstall_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ const (
ClusterBackendErrorMsg string = "The Spec could not be synced due to backend error:"
ClusterInputErrorReason string = "InputError"
ClusterInputErrorMsg string = "The Spec could not be synced due to an input error:"

ClusterLastInstallationPreparationFailedOKReason string = "There is no failing prior preparation attempt"
ClusterLastInstallationPreparationFailedErrorReason string = "The last installation preparation failed"
ClusterLastInstallationPreparationPending string = "Cluster preparation has never been performed for this cluster"
ClusterLastInstallationPreparationFailedCondition string = "LastInstallationPreparationFailed"
)

// +genclient
Expand Down
42 changes: 42 additions & 0 deletions api/vendor/github.com/openshift/assisted-service/models/cluster.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ea87037

Please sign in to comment.