-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main #14
Conversation
Reviewer's Guide by SourceryThis PR updates the GitHub Actions workflow configurations to trigger on the 'master' branch instead of 'main'. The change affects both push and pull request events in the CI and security scanning workflows. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CrzyHAX91 - I've reviewed your changes - here's some feedback:
Overall Comments:
- This PR changes the default branch from 'main' to 'master', which goes against current industry best practices for inclusive terminology. If there's a specific technical requirement for this change, please explain it in the PR description. Otherwise, we recommend keeping 'main' as the default branch name.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied ☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
Summary by Sourcery
CI: