Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #14

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Main #14

merged 3 commits into from
Dec 12, 2024

Conversation

CrzyHAX91
Copy link
Owner

@CrzyHAX91 CrzyHAX91 commented Dec 12, 2024

Summary by Sourcery

CI:

  • Update CI workflow configuration to trigger on 'master' branch instead of 'main'.

Copy link

sourcery-ai bot commented Dec 12, 2024

Reviewer's Guide by Sourcery

This PR updates the GitHub Actions workflow configurations to trigger on the 'master' branch instead of 'main'. The change affects both push and pull request events in the CI and security scanning workflows.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated branch trigger configurations in GitHub Actions workflows
  • Changed branch name from 'main' to 'master' for push events
  • Changed branch name from 'main' to 'master' for pull request events
.github/workflows/ci.yml
.github/workflows/njsscan.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CrzyHAX91 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This PR changes the default branch from 'main' to 'master', which goes against current industry best practices for inclusive terminology. If there's a specific technical requirement for this change, please explain it in the PR description. Otherwise, we recommend keeping 'main' as the default branch name.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@CrzyHAX91 CrzyHAX91 merged commit c3d914b into master Dec 12, 2024
9 of 10 checks passed
@CrzyHAX91 CrzyHAX91 deleted the main branch December 12, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant