Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump django-crispy-forms from 1.14.0 to 2.3 #23

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 13, 2024

Bumps django-crispy-forms from 1.14.0 to 2.3.

Release notes

Sourced from django-crispy-forms's releases.

2.3

What's Changed

  • Fixed unexpected addition the 'active' css_class to AccordionGroup

2.2

  • Added support for Django 5.1.
  • Allowed pass through of context when rendering a Fieldset layout object.

Full Changelog: django-crispy-forms/django-crispy-forms@2.1...2.2

2.1

What's Changed

  • Added support for Django 5.0.
  • Dropped support for Django 3.2, 4.0 and 4.1.
  • Added support for Python 3.12.
  • Dropped support for Python 3.7.

New Contributors

Full Changelog: django-crispy-forms/django-crispy-forms@2.0...2.1

2.0 (2023-02-13)

Major Changes and Migration Guide

  • Removed all Bootstrap template packs. These template packs are now available as standalone packages. To upgrade, install the required template pack and add it to your INSTALLED_APPS setting.

    Also, support for Bootstrap 5 is provided by a 3rd party package under the django-crispy-forms organisation at crispy-bootstrap5.

  • Removed uni-form template pack. Uni-Form specific classes previously added to every template pack e.g. textInput are now removed. If you require these classes, the previous behaviour can be restored by adding the following to CRISPY_CLASS_CONVERTERS in your settings file.

      converters = {
        "textinput": "textinput textInput",
        "fileinput": "fileinput fileUpload",
        "passwordinput": "textinput textInput",
    }
    

... (truncated)

Changelog

Sourced from django-crispy-forms's changelog.

2.3 (2024-07-19)

  • Fixed a bug in AccordionGroup rendering then it gets an unexpected css class active.

2.2 (2024-06-15)

  • Added support for Django 5.1.
  • Allowed pass through of context when rendering a Fieldset layout object.

2.1 (2023-10-15)

  • Added support for Django 5.0.
  • Dropped support for Django 3.2, 4.0 and 4.1.
  • Added support for Python 3.12.
  • Dropped support for Python 3.7.

See the 2.1 Milestone for the full change list.

2.0 (2023-02-13)

Release of django-crispy-forms 2.0. No changes introduced since 2.0a1.

2.0a1 (2023-01-18)

Major Changes and Migration Guide

  • Removed all Bootstrap template packs. These template packs are now available as standalone packages. To upgrade, install the required template pack and add it to your INSTALLED_APPS setting.

    Also, support for Bootstrap 5 is provided by a 3rd party package under the django-crispy-forms organisation at crispy-bootstrap5.

  • Removed uni-form template pack. Uni-Form specific classes previously added to every template pack e.g. textInput are now removed. If you require these classes, the previous behaviour can be restored by adding the following to CRISPY_CLASS_CONVERTERS in your settings file.

      converters = {
        "textinput": "textinput textInput",
        "fileinput": "fileinput fileUpload",
        "passwordinput": "textinput textInput",
    }
    
  • The uni-form template pack allowed for rendering of templates using a default or inline layout. As the uni-form template pack has been removed support for this has also been removed. This has resulted in the following BREAKING changes.

    • The form_style attribute of FormHelper is removed.
    • The form_style positional argument to render_field() is removed.
    • The form_style positional argument to the render() method of all LayoutObjects is removed.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Bump django-crispy-forms from version 1.14.0 to 2.3 to incorporate bug fixes, enhancements, and support for newer versions of Django and Python.

Bug Fixes:

  • Fix unexpected addition of the 'active' css_class to AccordionGroup in django-crispy-forms.

Enhancements:

  • Add support for Django 5.1 and Python 3.12 in django-crispy-forms.

Chores:

  • Drop support for Django 3.2, 4.0, 4.1, and Python 3.7 in django-crispy-forms.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 13, 2024
Copy link

sourcery-ai bot commented Dec 13, 2024

Reviewer's Guide by Sourcery

This PR updates django-crispy-forms from version 1.14.0 to 2.3, which includes major breaking changes in version 2.0 and several improvements in subsequent releases. The update involves significant architectural changes, particularly around template packs and form styling.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Major version upgrade with breaking changes in template packs
  • All Bootstrap template packs have been moved to standalone packages
  • Uni-form template pack has been removed
  • FormHelper's form_style attribute has been removed
  • render_field() and LayoutObjects render() methods no longer accept form_style parameter
dropship_project/requirements.txt
Framework compatibility updates
  • Added support for Django 5.0 and 5.1
  • Added support for Python 3.12
  • Dropped support for Django 3.2, 4.0, and 4.1
  • Dropped support for Python 3.7
dropship_project/requirements.txt
Bug fixes and improvements in recent versions
  • Fixed unexpected 'active' css_class addition to AccordionGroup
  • Added context pass-through when rendering Fieldset layout objects
dropship_project/requirements.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

@dependabot dependabot bot force-pushed the dependabot/pip/django-crispy-forms-2.3 branch from 7da3051 to 3fe2e77 Compare December 13, 2024 15:40
Bumps [django-crispy-forms](https://github.com/django-crispy-forms/django-crispy-forms) from 1.14.0 to 2.3.
- [Release notes](https://github.com/django-crispy-forms/django-crispy-forms/releases)
- [Changelog](https://github.com/django-crispy-forms/django-crispy-forms/blob/main/CHANGELOG.md)
- [Commits](django-crispy-forms/django-crispy-forms@1.14.0...2.3)

---
updated-dependencies:
- dependency-name: django-crispy-forms
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/django-crispy-forms-2.3 branch from 3fe2e77 to 4db9b63 Compare December 13, 2024 17:00
@CrzyHAX91 CrzyHAX91 merged commit ff529e5 into master Dec 13, 2024
3 of 5 checks passed
@CrzyHAX91 CrzyHAX91 deleted the dependabot/pip/django-crispy-forms-2.3 branch December 13, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant