-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O vs #28
Conversation
Reviewer's Guide by SourceryThis PR improves the OSV-Scanner GitHub workflow configuration by restructuring it for better readability and updating the workflow version reference. The changes maintain the same functionality while making the configuration more maintainable. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CrzyHAX91 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
# Scheduled and push scans | ||
scan-scheduled: | ||
if: ${{ github.event_name == 'push' || github.event_name == 'schedule' }} | ||
uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable.yml@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 suggestion (security): Consider pinning to a specific version instead of using @v1
Using @v1 will automatically accept all minor and patch updates within major version 1. For security-critical workflows, it's safer to pin to a specific version (e.g., @v1.0.0) to ensure deterministic behavior and avoid potential security issues from automatic updates.
Suggested implementation:
uses: google/osv-scanner-action/.github/workflows/[email protected]
Note: The version number @v1.4.1 used here is the latest stable release as of now. Before implementing, please verify this is still the latest stable release by checking:
https://github.com/google/osv-scanner-action/releases
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied ☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
|
Summary by Sourcery
CI: