dramatically simplified category templating implementation

FilterExtension/ConfigNodes/customCategory.cs

@@ -153,21 +153,8 @@ public void initialise()
                 }
 
                 customSubCategory sC = new customSubCategory(subcategory.toConfigNode());
-                if (subcategoryItem.applyTemplate && templates != null && templates.Any())
-                {
-                    List<Filter> baseSubCatFilters = new List<Filter>();
-                    foreach (Filter f in sC.filters)
-                        baseSubCatFilters.Add(new Filter(f)); // create independent copies
-                    sC.filters.Clear(); // create them from scratch
-                    foreach (Filter templateFilter in templates)
-                    {
-                        foreach (Filter f in baseSubCatFilters)
-                        {
-                            sC.filters.Add(new Filter(f));
-                            sC.filters.Last().checks.AddRange(templateFilter.checks);
-                        }
-                    }
-                }
+                if (subcategoryItem.applyTemplate)
+                    sC.template = templates;
 
                 try
                 {

FilterExtension/ConfigNodes/customSubCategory.cs

@@ -10,13 +10,14 @@ public class customSubCategory
         public string subCategoryTitle { get; set; } // title of this subcategory
         public string iconName { get; set; } // default icon to use
         public List<Filter> filters { get; set; } // Filters are OR'd together (pass if it meets this filter, or this filter)
+        public List<Filter> template { get; set; } // from the category, checked seperately
         public bool unPurchasedOverride { get; set; } // allow unpurchased parts to be visible even if the global setting hides them
 
         public bool hasFilters
         {
             get
             {
-                return filters.Any();
+                return filters.Any() || template.Any();
             }
         }
 
@@ -34,11 +35,13 @@ public customSubCategory(ConfigNode node)
             {
                 filters.Add(new Filter(subNode));
             }
+            template = new List<Filter>();
         }
 
         public customSubCategory(string name, string icon)
         {
             filters = new List<Filter>();
+            template = new List<Filter>();
             this.subCategoryTitle = name;
             this.iconName = icon;
         }
@@ -88,13 +91,7 @@ public bool checkFilters(AvailablePart part, int depth = 0)
             }
             if (!unPurchasedOverride && Core.Instance.hideUnpurchased && !ResearchAndDevelopment.PartModelPurchased(part) && !ResearchAndDevelopment.IsExperimentalPart(part))
                 return false;
-
-            foreach (Filter f in filters)
-            {
-                if (f.checkFilter(part, depth))
-                    return true;
-            }
-            return false; // part passed no filter(s), not compatible with this subcategory
+            return ((!template.Any() || template.Any(t => t.checkFilter(part, depth))) && filters.Any(f => f.checkFilter(part, depth))); // part passed a template if present, and a subcategory filter
         }
 
         /// <summary>