Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private preview/mqtt connect #1496

Closed
wants to merge 13 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Oct 18, 2023

Main branch for MQTT Service private preview user documentation. All further changes around this documentation should be merged into this branch only.
All changes will be merged into develop once MQTT Service will become public preview.

@github-actions
Copy link
Contributor

Preview available here

@ghost ghost force-pushed the private-preview/mqtt-connect branch from be9b19c to f586095 Compare October 18, 2023 07:21
@ghost ghost force-pushed the private-preview/mqtt-connect branch from c06eb19 to ca07530 Compare March 18, 2024 12:34
@BeateRixen
Copy link
Collaborator

@sagscmi This PR is still in draft mode. This means that is has not undergone a language review. I saw that shared the link to its preview as the feature is available now as Private Preview. Should I better do a review now?

|   | TCP |
|:-----|:----|
| TLS | 9883 |
| no TLS | 2883 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from Niko in Bugherd:

"Why do we plan to allow unencrypted communication? Unless there is a very strong reason, we should only allow for encrypted communication."

https://softwareag-c8y-docs-build-pr-1496.surge.sh/device-integration/mqtt-service/

@BeateRixen
Copy link
Collaborator

@slc-softwareag This PR is still in draft mode. Draft mode means that we will not start our language review as you are still working on the content. But it seems that the documentation has already been shared with some customers, so it should better be reviewed. Can you please remove the draft mode and have a label "not-yet-deployed" which tells us that the PR should not yet get merged?

@ghost ghost force-pushed the private-preview/mqtt-connect branch from 53e0804 to 8eb7904 Compare April 19, 2024 06:46
@ghost ghost added the not-yet-deployed label Apr 19, 2024
@ghost ghost marked this pull request as ready for review April 19, 2024 06:47
@ghost ghost requested review from BeateRixen and MWindel as code owners April 19, 2024 06:47
@scmi-c8y scmi-c8y removed the Draft label Apr 19, 2024
@schmiel-cumulocity schmiel-cumulocity self-assigned this Oct 30, 2024
…#2603)

* MTM-61476: Add section describing how to use mqtt service error topic

* MTM-61476: Implement suggestions from PR

* MTM-61476: Improve readability of per-client topic explanation

* Apply suggestions from code review

* MTM-61476: Directly refer to MQTT specification when describing MQTT 3.1.1 error behaviour

* Apply suggestions from code review

* MTM-61476: Improve readability of sentence

---------

Co-authored-by: Marlene Windel <[email protected]>
@scmi-c8y
Copy link
Contributor

scmi-c8y commented Dec 3, 2024

Replaced by #2695

@scmi-c8y scmi-c8y closed this Dec 3, 2024
@scmi-c8y scmi-c8y deleted the private-preview/mqtt-connect branch December 3, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants