Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cockpit screenshots #2844

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Replace cockpit screenshots #2844

wants to merge 5 commits into from

Conversation

reey
Copy link
Collaborator

@reey reey commented Jan 24, 2025

No description provided.

@reey reey self-assigned this Jan 24, 2025
Copy link
Contributor

Preview available here

@BeateRixen
Copy link
Collaborator

@reey Some of the screenshots do not have the right size. Please see our standards in https://docs.google.com/document/d/1geBLxk35ZIiS8C2Uo15H-14oneuEEKRf0eerHqdm3fw/edit?tab=t.0#heading=h.vohz2pwy651q. This especially applies to those showing the full screen. The browser should have a width of 1440 px when taking screenshots to make them consistent in size.

@reey
Copy link
Collaborator Author

reey commented Jan 27, 2025

@reey Some of the screenshots do not have the right size. Please see our standards in https://docs.google.com/document/d/1geBLxk35ZIiS8C2Uo15H-14oneuEEKRf0eerHqdm3fw/edit?tab=t.0#heading=h.vohz2pwy651q. This especially applies to those showing the full screen. The browser should have a width of 1440 px when taking screenshots to make them consistent in size.

@BeateRixen I've adjusted the screenshots.

@BeateRixen
Copy link
Collaborator

@reey One more picky thing. The user icon shows "JD", probably Jakub. We usually avoid this and show A (Admin) as a more neutral user. If this is an easy change, could you please replace it (affect around 10 screenshots). Probably an easy copy/paste.

@reey
Copy link
Collaborator Author

reey commented Jan 28, 2025

@reey One more picky thing. The user icon shows "JD", probably Jakub. We usually avoid this and show A (Admin) as a more neutral user. If this is an easy change, could you please replace it (affect around 10 screenshots). Probably an easy copy/paste.

The user that we use in the screenshots is called "John Doe" ([email protected]). Therefore "JD" shows up.
If there is a specific other user name to be expected, please provide a firstname, lastname and mail for this user.

@BeateRixen
Copy link
Collaborator

@reey One more picky thing. The user icon shows "JD", probably Jakub. We usually avoid this and show A (Admin) as a more neutral user. If this is an easy change, could you please replace it (affect around 10 screenshots). Probably an easy copy/paste.

The user that we use in the screenshots is called "John Doe" ([email protected]). Therefore "JD" shows up. If there is a specific other user name to be expected, please provide a firstname, lastname and mail for this user.

Good point, I will add this to the guidelines. Let´s leave it as is then. I like this "John Doe" suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants