Fix AI teammate competition causing "suicide" behavior in intelligence card disputes #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AI players were sometimes competing against their own teammates for intelligence cards, leading to wasteful "suicide" behavior where teammates would fight each other instead of cooperating against enemies.
Example scenario from the issue:
coefficientA
,coefficientB
) caused teammates to competeRoot Cause
Each AI player independently calculated intelligence card values using their own personality coefficients (random multiplier 0.8-1.2, additive -15 to +15). Small value differences could flip due to personality variations, causing teammates to compete for marginal gains.
Solution
Added minimal teammate coordination logic in
RobotPlayer.shouldAvoidTeammateCompetition()
:Key Features
isPartnerOrSelf()
logic correctlyTesting
Fixes #372.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.