Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CIQ extension to use mixbox. Fix #260. #265

Merged
merged 2 commits into from
Jun 29, 2015
Merged

Update CIQ extension to use mixbox. Fix #260. #265

merged 2 commits into from
Jun 29, 2015

Conversation

gtback
Copy link
Contributor

@gtback gtback commented Jun 23, 2015

I added a basic test to verify the extension works, but not much more than that. The test is pretty fragile, but better than nothing.

@bworrell: If you're OK with this, go ahead and merge. Otherwise, let me know what else you were planning as part of #260.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling b2cf273 on CybOXProject:ciq into c889ade on CybOXProject:master.

@gtback
Copy link
Contributor Author

gtback commented Jun 23, 2015

Bah! I can fix the errors on py32, py33, py34 by using six.StringIO, but I don't know what to do about RHEL6.

  • Skip the test entirely on in rhel6?
  • Bump the required version of LXML package-wide?

Thoughts?

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 681b69f on CybOXProject:ciq into c889ade on CybOXProject:master.

@bworrell
Copy link
Contributor

Maybe for now we just exclude the test in rhel6 and see what comes of #266. We might be able to fix this by dropping lxml.

@gtback gtback merged commit 681b69f into master Jun 29, 2015
gtback added a commit that referenced this pull request Jun 29, 2015
@gtback gtback deleted the ciq branch June 29, 2015 13:39
@gtback
Copy link
Contributor Author

gtback commented Jun 29, 2015

Thanks, @bworrell. I ended up using some hackery to skip the test. I couldn't just use skipTest() without more hackery.

@bworrell
Copy link
Contributor

Haha, I figured you were going to use the --exclude option for nose in our tox.ini file. Something like:

[testenv:rhel6]
basepython=python2.6
commands =
    nosetests cybox --exclude="ciq_test.py"
deps =
    lxml==2.2.3
    mixbox>=0.0.7
    python-dateutil==1.4.1
    nose

I'm not sure if that'd work at all but it's kinda how i was thinking about skipping it for rhel6.

@gtback
Copy link
Contributor Author

gtback commented Jun 29, 2015

Oh, I didn't know about that. Oops.

@gtback
Copy link
Contributor Author

gtback commented Jun 29, 2015

Updated in 370e540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants