Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security improvements to docker deployment #32

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shadyeip
Copy link

  • Added reverse proxy to forward 443 to 5000.
  • Updated app services to bind to localhost, only exposing reverse proxy to the host.
  • Added self-signed cert generation.
  • Added ability to use custom certs. Simply create a directory called certs in the nginx directory, and add cert (nginx.crt) and key (nginx.key) to it.

@turnernator1
Copy link
Collaborator

Hi @shadyeip

Thanks for the PR! Looks like some awesome improvements.

We will review and aim to merge ASAP.

@shadyeip
Copy link
Author

shadyeip commented Dec 6, 2024

There's a bug in nginx conf file that prevents screenshot uploads, I'll push a fix when I get a chance. Otherwise, this has been working well for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants