adds proper sell rounding to avoid LOT errors #79
Conversation
… using an editor; adds handling when someone uses a version without trailing loss/profit; adds .gitignore; updates SDK to recent version
Binance Detect Moonings.py
Outdated
|
|
||
| sell_amount = coins_bought[coin]['volume'] | ||
| tick_size = float(next( | ||
| filter(lambda f: f['filterType'] == 'LOT_SIZE', client.get_symbol_info(coin)['filters']) |
There was a problem hiding this comment.
maybe you can cache lot_size into coins_bought.json
There was a problem hiding this comment.
Makes perfect sense. I'll implement it.
adds try/except instead of if
|
Been running this version for some hours now. Not even one error occured. :) |
|
Been testing for a while here too, and so far no errors. Thanks! |
|
@CyberPunkMetalHead this one seems important to merge |
|
@hExPY Can you please resolve conflicts? |
|
Was on vacation. Now I merged. :) |
Binance Detect Moonings.py
Outdated
| try: | ||
| TP = float(coins_bought[coin]['bought_at']) + ( | ||
| float(coins_bought[coin]['bought_at']) * coins_bought[coin]['take_profit']) / 100 | ||
| SL = float(coins_bought[coin]['bought_at']) + ( | ||
| float(coins_bought[coin]['bought_at']) * coins_bought[coin]['stop_loss']) / 100 | ||
| # When an older version of the script is being executed | ||
| except KeyError: | ||
| TP = float(coins_bought[coin]['bought_at']) + (float(coins_bought[coin]['bought_at'])) / 100 | ||
| SL = float(coins_bought[coin]['bought_at']) + (float(coins_bought[coin]['bought_at'])) / 100 |
There was a problem hiding this comment.
Wouldn't be a good idea to put coins_bought[coin]['bought_at'] into a variable to avoid repeating it too much?
Code might be cleaner
| tick_size = float(next( | ||
| filter(lambda f: f['filterType'] == 'LOT_SIZE', client.get_symbol_info(coin)['filters']) | ||
| )['stepSize']) |
There was a problem hiding this comment.
This line seems to be too long. Is there any way to make it more readable? (I really don't know)
There was a problem hiding this comment.
Haven't tested this yet, will it leave crypto dust for people using BNB for fees?
There was a problem hiding this comment.
Yep, it will leave crypto dust which can be changed into BNB afterward.
adds code review changes
| TP = BuyPrice + (BuyPrice) * coins_bought[coin]['take_profit']) / 100 | ||
| SL = BuyPrice + (BuyPrice) * coins_bought[coin]['stop_loss']) / 100 |
There was a problem hiding this comment.
This code doesn't run. Remove the extraneous parenthesis:
| TP = BuyPrice + (BuyPrice) * coins_bought[coin]['take_profit']) / 100 | |
| SL = BuyPrice + (BuyPrice) * coins_bought[coin]['stop_loss']) / 100 | |
| TP = BuyPrice + (BuyPrice) * coins_bought[coin]['take_profit'] / 100 | |
| SL = BuyPrice + (BuyPrice) * coins_bought[coin]['stop_loss'] / 100 |
Adds proper coin rounding in order to fix LOT error; reformat file; adds handling when someone uses a version without trailing loss/profit; adds .gitignore; updates SDK to recent version