Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont use internal types/classes in public API #1202

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jan 9, 2025

fixes #1192

since these classes were never public, it is just non-breaking to use public type-aliases instead.

@jkowalleck jkowalleck requested a review from a team as a code owner January 9, 2025 08:02
@jkowalleck jkowalleck added the enhancement New feature or request label Jan 9, 2025
@jkowalleck jkowalleck changed the title fix: dont use private types/classes in public API dont use private types/classes in public API Jan 9, 2025
@jkowalleck jkowalleck changed the title dont use private types/classes in public API dont use internal types/classes in public API Jan 9, 2025
Copy link

codacy-production bot commented Jan 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0e4e14f) 25023 24628 98.42%
Head commit (eccc1cb) 25113 (+90) 24718 (+90) 98.43% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1202) 36 36 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck force-pushed the feat/no-public-use-of-private-api_1 branch 2 times, most recently from 9aea2de to 7b191b9 Compare January 9, 2025 08:22
@jkowalleck jkowalleck force-pushed the feat/no-public-use-of-private-api_1 branch from 7b191b9 to eccc1cb Compare January 9, 2025 08:24
@jkowalleck jkowalleck merged commit 8932743 into main Jan 9, 2025
45 checks passed
@jkowalleck jkowalleck deleted the feat/no-public-use-of-private-api_1 branch January 9, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't use internals for public API
1 participant