serialization filter: any one expressen preferred #371

jkowalleck · 2023-04-03T17:10:24Z

fixes #365

implementation according to #365 (comment)

outpur is about to change,
so this is seen as a breaking change !

cyclonedx/serialization/__init__.py

tests/test_regression365.py

cyclonedx/serialization/__init__.py

tests/test_regression365.py

cyclonedx/serialization/__init__.py

tests/test_regression365.py

cyclonedx/serialization/__init__.py

tests/test_regression365.py

Signed-off-by: Jan Kowalleck <[email protected]>

sonatype-lift · 2023-06-15T18:09:55Z

tests/data.py

        author='Test Author'
    )

-
 def get_component_setuptools_simple_no_version(bom_ref: Optional[str] = None) -> Component:


E302: expected 2 blank lines, found 1

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T18:09:57Z

tests/test_regression365.py

+        product(_bom_getters, ['json'], [JsonV1Dot4, JsonV1Dot3, JsonV1Dot2]),
+    ))
+    @unpack
+    def test_serialize(self, bom_getter: Callable[[], Bom], target: str, schema_type: Union[Type[Json], Type[Xml]]) -> None:


E501: line too long (124 > 120 characters)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T18:09:59Z

cyclonedx/serialization/__init__.py

+    @classmethod
+    def deserialize(cls, o: object) -> List[LicenseChoice]:
+        raise NotImplementedError
+        return [LicenseChoice.from_json(data) for data in o]


E1101: Class 'LicenseChoice' has no 'from_json' member

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T18:10:00Z

tests/data.py

+    """
+    bom_expression = get_bom_for_issue_365_expression()
+    bom_multi = get_bom_for_issue_365_multiple_licenses()
+    component_multi: Component = bom_multi.components[0]


reportGeneralTypeIssues: Argument of type "Literal[0]" cannot be assigned to parameter "index" of type "slice" in function "getitem"
"Literal[0]" is incompatible with "slice"

❗❗ 3 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

tests/data.py 437

tests/data.py 438

tests/data.py 438

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T18:10:02Z

cyclonedx/serialization/__init__.py

+    @classmethod
+    def deserialize(cls, o: object) -> List[LicenseChoice]:
+        raise NotImplementedError
+        return [LicenseChoice.from_json(data) for data in o]


vulture-100: unreachable code after 'raise'

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

jkowalleck added the bug Something isn't working label Apr 3, 2023

jkowalleck requested a review from a team as a code owner April 3, 2023 17:10

jkowalleck mentioned this pull request Apr 3, 2023

[BUG] Schema-invalid serialized result when multiple licenses #365

Closed

jkowalleck force-pushed the maybe-fix-issue365 branch from 1b5c134 to dc8d354 Compare April 3, 2023 17:13

jkowalleck marked this pull request as draft April 3, 2023 17:13

jkowalleck force-pushed the maybe-fix-issue365 branch from 733c55b to 087fd32 Compare June 15, 2023 11:25

sonatype-lift bot reviewed Jun 15, 2023

View reviewed changes

cyclonedx/serialization/__init__.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed Jun 15, 2023

View reviewed changes

tests/test_regression365.py Outdated Show resolved Hide resolved