-
-
Notifications
You must be signed in to change notification settings - Fork 67
feat: Add support for TLP marking in metadata #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d456e1
to
5d5201f
Compare
e7f1f82
to
1fd2561
Compare
Signed-off-by: anthonyharrison <[email protected]>
Signed-off-by: anthonyharrison <[email protected]>
CycloneDX#595) Signed-off-by: anthonyharrison <[email protected]>
a767891
to
55425e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some documentation here and there, and properly set the default values?
for backwards compatibility reasons, i would not set "CLEAR" as the default value. clean means a decision actively was made, right? in JSON, this would mean no default is defined, and the property is optional. |
I see CLEAR as the default when the user makes no choice as the user is more likely to explicitly state one of the other values (which indicates that he has thought about the constraints as regards sharing the BOM). Personally, I would prefer to see all BOMs to have the TLP value explicitly stated but that is possibly too much to expect at this stage. |
…d documentation (fixes CycloneDX#595) Signed-off-by: anthonyharrison <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
tools/src/test/resources/1.7/valid-metadata-distribution-1.7.textproto
Outdated
Show resolved
Hide resolved
I'll try to fix the open issues ASAP |
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
…on (fixes CycloneDX#595) Signed-off-by: anthonyharrison <[email protected]>
# Conflicts: # schema/bom-1.7.proto # schema/bom-1.7.schema.json # schema/bom-1.7.xsd
…on (fixes CycloneDX#595) Signed-off-by: anthonyharrison <[email protected]>
@anthonyharrison, the current state looks promising. According to the CycloneDX working model, the next step would be to move from "prototype" to "draft", meaning the community review phase (RFC) would start. |
@jkowalleck Let's go to the next stage and see what the community thinks. I have no outstanding changes. |
RFC notice sent.
Public RFC period ends April 13, 2025 |
All current discussuons are basically too late. Public RFC ended on 13. of April. This feature is promoted to become standardized under Ecma. Vote will be on 1. May. Please do not alter the current state last minute. |
This feature was just appoved by Ecma TC54 👍 |
As discussed in ticket #595, this PR adds TLP marking in the BOM metadata.
This PR superseeds #603
fixes #595