Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library folder not included in the source distribution #183

Open
BastienFaure opened this issue Jun 4, 2024 · 1 comment
Open

library folder not included in the source distribution #183

BastienFaure opened this issue Jun 4, 2024 · 1 comment
Labels
query-library Query library related (library/*)

Comments

@BastienFaure
Copy link

BastienFaure commented Jun 4, 2024

Describe the bug
The library folder is not included in the source distribution built and sent to Pypi:

$ tar tf raven_cycode-1.0.9.tar.gz |grep library | wc -l
0

Thus, when installing raven-cycode using pip and the pypi repository, the library folder isn't available and causes certain commands to fail:

$ raven report --format raw 
2024-06-04 14:31:42 | ERROR    | [Errno 2] No such file or directory: 'library'

To Reproduce

$ pipx install raven-cycode
$ raven report --format raw 

Expected behavior
The library folder should be shipped in the source distribution by including them in the package's manifest and by instructing setuptools to include package data during installation. To my knowledge, this is possible only by moving the library folder into the source package tree, otherwise it will likely pollute the Python library namespace.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Fedora 39
  • Python 3.12.3
  • Raven 1.0.9

Additional context
Side note, currently the package used the folder src in the Python package namespace, which is also confusing. I suggest it to be renamed to something like raven if it doesn't conflict with other packages namespaces, at least less likely than src.

@elad-pticha elad-pticha added the query-library Query library related (library/*) label Jun 16, 2024
@elad-pticha
Copy link
Contributor

Hey and thank you for opening this issue, we will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
query-library Query library related (library/*)
Projects
None yet
Development

No branches or pull requests

2 participants