Include library folder in Python packages
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age through MANIFEST and allow their installation with setuptools
…ly to the Docker image
|
Hey and thank you soo much for opening this PR. I think we could leave the |
elad-pticha
reviewed
Jun 16, 2024
| @@ -1,3 +1,4 @@ | |||
| include README.md LICENSE requirements.txt main.py | |||
| recursive-include src/library *.yml | |||
There was a problem hiding this comment.
Change to library *.yml
elad-pticha
reviewed
Jun 16, 2024
| CMD ["make", "test-run"] |
There was a problem hiding this comment.
Remove extra line added
elad-pticha
reviewed
Jun 16, 2024
| @@ -45,4 +45,5 @@ | |||
| install_requires=REQUIRMENTS, | |||
| packages=find_packages(exclude=("tests", "tests.*")), | |||
| entry_points={"console_scripts": ["raven = src.cmdline:execute"]}, | |||
| include_package_data=True, | |||
There was a problem hiding this comment.
Is this required?
I tried to build the package without this, and it worked. Is there something I am missing?
elad-pticha
requested changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #183