Session based communication with private servers #151
Conversation
ujjwal-cyph
changed the title
|
@ujjwal-cyph I have made the required changes for the session initiation phase and added the necessary utility methods |
| @@ -0,0 +1,138 @@ | |||
| #include "session_utils.h" | |||
There was a problem hiding this comment.
add license headers
this comment is applicable to other files too.
There was a problem hiding this comment.
license header missing in atecc_utils.c
src/controller_main.c
Outdated
| @@ -171,6 +171,9 @@ Flash_Wallet wallet_for_flash; | |||
| MessageData msg_data; | |||
| ui_display_node *current_display_node = NULL; | |||
|
|
|||
| // create a new session object | |||
| Session session; | |||
There was a problem hiding this comment.
this need not be global. it can be local variable to the session.c.
src/controller_main.c
Outdated
| &session_init_details); | ||
|
|
||
| if (!session_init(&session, &session_init_details)) { | ||
| LOG_CRITICAL("xxec %d:%d", false, __LINE__); |
There was a problem hiding this comment.
log only required values. false is hardcoded here
common/libraries/util/atecc_utils.c
Outdated
| uint8_t *data, | ||
| uint8_t *digest, | ||
| uint8_t *postfix, | ||
| atecc_data_t atecc_value) { |
There was a problem hiding this comment.
this is wrong. pass by value won't achieve what we want. the data updated by the function would not reflect in the original instance of the struct.
| atecc_data_t atecc_value) { | |
| atecc_data_t atecc_value) { |
| * Licensor: HODL TECH PTE LTD | ||
| * | ||
| ****************************************************************************** | ||
| */ |
There was a problem hiding this comment.
full license is added only in the source files. headers only have the short version.
| uint8_t data_key_id, | ||
| atecc_data_t *atecc_value); | ||
|
|
||
| auth_data_t atecc_sign(uint8_t *hash); |
No description provided.