handle and launch on multiple screens #976
Conversation
|
Any suggestions on how this could be tested without access to more physical screens? |
|
It should work with wireless displays as well. I think you should be able to cast to pretty much any laptop over wifi if you do not have other miracast devices and no thunderbolt capable android device. In android Q, there would also be a developer option to create a virtual display to a window directly on the device. |
+ immersive fullscreen when hardware keyboard is present + if hardware input & external display available, display kept on This is to support a more "desktop mode" linux when the device is docked (having both hardware keyboard and an external display).
|
Thank |
|
Changed the "desktop mode" commit description, and added FLAG_KEEP_SCREEN_ON for the external display when both hardware keyboard and external display are available. I would have expected this to keep the external display awake, while allowing the phone screen to sleep when working on the activity on the external display; but at least my device keeps both the phone display and the external display awake (this is probably an issue in Android, need to investigate further eventually). |
|
I am sorry we never got back to this. We had a large funding change about the time we were discussion this with you. I will look at this, this week or next. It looks like pretty good work. |
|
How |
|
I'd be willing to test this with Samsung DeX + the phone screen mirrored to a second monitor via DisplayLink adapter. Would that be a matter of cloning the branch repo to local storage and then pointing F-Droid at it, or is there a more involved build process? |
Note
Pull requests should follow the git flow described in the wiki.
To get git history clean and aid in more useful release notes, it is essential to use the
Squash and mergeoption whenmerging into 'master', and the
Create merge commitoption when merging into 'releases'.What changes does this PR introduce?
Fixes an issue with view changes starting multiple new sessions.
Launches and migrates sessions to external screens, when they are plugged in (and back to device screen when they are plugged out).
Any background context you want to provide?
I am venturing into the maddeningly recursive depths of actually doing development on Android (eventually for Android). Having an external screen that works seamlessly is nearly a requirement for this.
Where should the reviewer start?
Simple change, just look through it all.
Has this been manually tested? How?
Plugging & unplugging a USB monitor to an Android-Q Oneplus 7 developer preview 3. Connecting & disconnecting a Bluetooth keyboard on the same device.
What value does this provide to our end users?
Fullscreen desktop-like experience when external monitors are plugged in while running UserLAnd.
What GIF best describes this PR or how it makes you feel?