Support for firing add event for initial elements #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadashiA
commented
Feb 1, 2024
| filter.InvokeOnAttach(value, view); | ||
| if (invokeAddEventForCurrentElements) | ||
| { | ||
| filter.InvokeOnAdd(value, view, NotifyCollectionChangedEventArgs<T>.Add(value, -1)); |
There was a problem hiding this comment.
Could not support getting the index of the SortedView source here.
In the current implementation, the index that can be obtained with ISynchronizedViewFilter.OnCollectionChanged is, from the source of IObservableCollection.
However, perhaps it should be the index of the ISynchronizedView (?)
There was a problem hiding this comment.
If #22 is adopted, indexes can be supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an AttachFilter is executed, CollectionChangeEvent will not fire for elements that already exist.
(WhenTrue/WhenFalse will fire)
If you are performing some destructive operation on a View (GameObject, etc.) with a CollectionChangeEvent, it may be bad if you cannot apply the same process to an already existing element.
So I added the following overload:
AttachFilter<>(filter, bool invokeAddEventForInitialElements = false)( It may not be a very pretty solution..)