Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change WritableView implementation #82

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Change WritableView implementation #82

merged 5 commits into from
Oct 18, 2024

Conversation

zerodev1200
Copy link
Contributor

#75
I have added a sample to sandbox-WpfApp, so I would like you to check it out.
I have also added the ability to delete rows using the Delete key on the keyboard.

@neuecc
Copy link
Member

neuecc commented Oct 18, 2024

Thank you!
The very large implementation is extremely helpful, great!

@neuecc neuecc merged commit b000cc8 into Cysharp:master Oct 18, 2024
1 check passed
@zerodev1200
Copy link
Contributor Author

I'm glad to hear you say that!
However, I just remembered one thing that I missed.
I need to add public override bool IsReadOnly => false; to ObservableListSynchronizedViewList<T> in ObservableList.OptimizeView.cs
There may be other things that need attention as well.
I'd appreciate it if you could review them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zerodev1200 @neuecc