Improve synchronization handling in event dispatcher #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'll be okay, probably...! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for the consecutive pull requests.
Regarding
WritableView, I noticed that an exception occurs when adding items to the DataGrid while usingToWritableNotifyCollectionChanged(SynchronizationContextCollectionEventDispatcher.Current).Upon checking, it seems necessary to separate the handling of UI operations on the DataGrid and asynchronous collection operations in
SynchronizationContextCollectionEventDispatcher.Post().The UI operations and asynchronous collection operations worked fine with the code in this PR, but I am concerned about whether this code is appropriate and if there are any unintended consequences.
Let me know if you need any tweaks!