Problem of status code being StatusCode.Internal in Airplane mode, etc. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to pass the exception (IOException) as InnerException to HttpRequestException, which is thrown when an exception occurs when getting results with `ResponseContext.GetResponseAsync`. `Grpc.Net.Client` has an implementation that interprets the StatusCode as Unavailable if an exception derived from SocketException is included as InnerException among HttpRequestExceptions. In the current YetAnotherHttpHandler, InnerException is not set, so when an error occurs in an offline state, the StatusCode becomes Internal, and the behavior is different from when using the genuine HttpHandler.
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grpc.Net.Client has an implementation that interprets the StatusCode as Unavailable if an exception derived from SocketException/IOException is included as InnerException among HttpRequestExceptions. In the current YetAnotherHttpHandler, InnerException is not set, so when an error occurs in an offline state, the StatusCode becomes Internal, and the behavior is different from when using the genuine HttpHandler.
Changed to pass the exception (IOException) as InnerException to HttpRequestException, which is thrown when an exception occurs when getting results with ResponseContext.GetResponseAsync.