Fix: .NET Standard 2.0 Shims unsafe span overloads #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix shims for .NET Standard 2.0: correct pointer-based Encoding overload usage and add guards for empty spans.
Problem
GetBytes/GetStringused span pinning paths that misbehave on empty spans under .NET Standard 2.0. Problem occurs when logging empty string with exceptionThe line above is logged in .NET 8 clients, but not in .net framework clients - the Shims throw IndexOutOfRange exception because the message is empty, but the shim attempts to get first character.
Fix
Encoding.GetBytes/GetStringsafely.Tests