Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed + improved dv-dataset-destroy-migration-placeholder #54

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

janvanmansum
Copy link
Contributor

No JIRA

Description of changes

  • Implemented missing dry-run option for dv-dataset-destroy-migration-placeholder
  • Refactored filtering on datasets with only 'easy-migration' files + also allowing easy-migration.zip as 'easy-migration' file (formerly, easy-migration was expected to be a directory containing up to 4 files).

Notify

@DANS-KNAW/core-systems

…ognizes easy-migration.zip

as a placeholder file, and not only and easy-migration folder.
…-placeholder

- Refactored filtering on datasets with only 'easy-migration' files + also allowing easy-migration.zip as 'easy-migration' file (formerly, easy-migration
was expected to be a directory containing up to 4 files).
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0b4debf) 42.98% compared to head (3f68389) 41.66%.

Files Patch % Lines
...tastation/dataverse/destroy_placeholder_dataset.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   42.98%   41.66%   -1.32%     
==========================================
  Files          17       18       +1     
  Lines         784      828      +44     
==========================================
+ Hits          337      345       +8     
- Misses        447      483      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janvanmansum janvanmansum merged commit cedc59f into DANS-KNAW:master Feb 14, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant