DD-1625 deposit-create-report: stuur geen report als er geen records zijn #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DD-1625 deposit-create-report: stuur geen report als er geen records zijn
Description of changes
deposit-creat-reportscript checked for an empty report, it is when there are no selected/filtered records. If it is empty, it doesn't send emails to recipients.Note:
The an empty response of the server is dependent on the
Acceptheader:{'Accept': 'text/csv'}--> ' '{'Accept': 'application/json'}--> []How to test
For example run in vagrant:
/usr/local/bin/deposit-create-report --user 001 --email-to <your email>--> should get an email/usr/local/bin/deposit-create-report --user 010 --email-to <your email>--> should not get an emailRelated PRs
(Add links)
Notify
@DANS-KNAW/core-systems