DD-1637 Add age option to deposit-createreport script #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-pol
reviewed
Sep 10, 2024
| @@ -56,6 +62,9 @@ def main(): | |||
| parser.add_argument('--bcc-email-to', dest='bcc_email_to', help='will be sent only if email-to is defined') | |||
| args = parser.parse_args() | |||
|
|
|||
| if args.age is not None and str(args.age).isnumeric(): # Note: args is a Namespace object | |||
There was a problem hiding this comment.
You can just tell argparse it should be in an int at line 54.
There was a problem hiding this comment.
janvanmansum
requested changes
Sep 16, 2024
| @@ -56,6 +62,9 @@ def main(): | |||
| parser.add_argument('--bcc-email-to', dest='bcc_email_to', help='will be sent only if email-to is defined') | |||
| args = parser.parse_args() | |||
|
|
|||
| if args.age is not None and str(args.age).isnumeric(): # Note: args is a Namespace object | |||
There was a problem hiding this comment.
janvanmansum
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DD-1637 age optie voor deposit-create-report
Description of changes
added to
~/git/dans-core-systems/modules/dans-datastation-tools/src/datastation/deposit_create_report.pyadd_argument('-a', '--age', dest='age', help='the number of days before today ')When it is given in the command line, it will set the startdate argument to asked date, if it is an integer,
How to test
For example, in vagrant ssh:
python3 /vagrant/modules/dans-datastation-tools/src/datastation/deposit_create_report.py --helpRelated PRs
(Add links)
Notify
@DANS-KNAW/core-systems