DD-1640 deposit-create-report should handle comma separated arguments #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvanmansum
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Use repeatable options instead. See comment in issue.
Hi @janvanmansum, it is done.
janvanmansum
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DD-1640 deposit-create-report should handle comma separated arguments
Description of changes
deposit-create-reportwill give repeatable arguments:--userand--statethrough tomanage-depositand they will give correctly to thedd-manage-depositeservice.How to test
--state ACCEPTED --state INVALID --user user001 --user user002-t ACCEPTED -t INVALID -u user001 -u user002-t ACCEPTED -t INVALID -u user001-t ACCEPTED -u user001 -u user002-t ACCEPTED -t INVALID-u user002-t INVALIDRelated PRs
(Add links)
Notify
@DANS-KNAW/core-systems