-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry dataset publication on awaiting indexing failure #45
Retry dataset publication on awaiting indexing failure #45
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
============================================
- Coverage 36.47% 35.55% -0.93%
Complexity 261 261
============================================
Files 80 80
Lines 1113 1142 +29
Branches 42 45 +3
============================================
Hits 406 406
- Misses 699 728 +29
Partials 8 8
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I am having a hard time reproducing the problem that this solves, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See comments
- Test with remote debug + suspending indexing thread in Dataverse
Reviewed and tested with Paul. |
Fixes DD-1433
Description of changes
When a dataset publish is requested with the option to assure indexing, the result might be a failure 409 status code.
This PR will then try to publish again, with a delay and a maximum number of retries.
If another failure happens or the max retries is reached without success, the publish fails.
How to test
Related PRs
(Add links)
Notify
@DANS-KNAW/dataversedans