Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1445 Add submitForReview #47

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

janvanmansum
Copy link
Contributor

Fixes DD-

Description of changes

How to test

Related PRs

(Add links)

Notify

@DANS-KNAW/dataversedans

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0889188) 35.55% compared to head (52868c7) 35.42%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
- Coverage     35.55%   35.42%   -0.13%     
  Complexity      261      261              
============================================
  Files            80       81       +1     
  Lines          1142     1146       +4     
  Branches         45       45              
============================================
  Hits            406      406              
- Misses          728      732       +4     
  Partials          8        8              
Files Coverage Δ
...in/java/nl/knaw/dans/lib/dataverse/DatasetApi.java 0.00% <0.00%> (ø)
...dataverse/model/dataset/SubmitForReviewResult.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janvanmansum janvanmansum changed the title WIP DD-1445 Add submitForReview Oct 31, 2023
@janvanmansum janvanmansum marked this pull request as ready for review October 31, 2023 11:46
@janvanmansum janvanmansum requested a review from a team as a code owner October 31, 2023 11:46
@janvanmansum
Copy link
Contributor Author

Reviewed with @PaulBoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant