Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1698 + DD-1699: 1.4-DANS-PATCH-1 video #7

Closed
wants to merge 61 commits into from

Conversation

jo-pol
Copy link

@jo-pol jo-pol commented Feb 6, 2025

Differences between directories v1.4 and v1.4-DANS-PATCH-1

  • preview.css (max-width/height) DD-1699
  • video.js (subtitles, even in draft) DD-1698
    • When a user received permission for the video but (not asked) for the vtt files, the language tags show up but don´t work
    • user friendly mime type for vtt appears as "unknown" should be something like "Web Video Text Track"
      https://developer.mozilla.org/en-US/docs/Web/API/WebVTT_API
    • inline preview does not count as download, preview on separate page does count as download, Is that correct?

Changes of 3ffeb84 are merged into

not specified but implemented

  • desired languages: &locale=en has precedence over preferred languages as set in the browser
  • available languages extracted from "baseName.en.vtt", "baseName.de-CH.vtt" or "baseName.vtt"
  • sorts 'de-CH' before 'de'
  • per language first a full match is tried, then the main language
  • when the depositor does not provide a default, the first language is the default

Test data

Quick test:

scp previewers/v1.4-DANS-PATCH-1/js/video.js [email protected]:/var/www/html/dataverse-previewers-1.4/js/video.js
scp previewers/v1.4-DANS-PATCH-1/js/video.js [email protected]:/var/www/html/dataverse-previewers-1.4/css/previe.css

Official install:

deploy.py -m install-previewers

with the following changes for datastations.yml#L1184

shared_dataverse_previewers_version: '1.4-DANS-PATCH-1'
shared_dataverse_previewers_source_account: 'DANS-KNAW'


zip_url: 'https://github.com/{{ shared_dataverse_previewers_source_account }}/dataverse-previewers/archive/refs/tags/{{ shared_dataverse_previewers_version }}.zip'

pdurbin and others added 30 commits May 17, 2023 14:47
allow NcML preview to work with drafts gdcc#25
Updates to Betatest/v1.4 prerelease
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.7 to 3.2.8.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v3.2.8/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v3.2.8/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
…rs/react-source/hdf5-previewer/follow-redirects-1.15.4

Bump follow-redirects from 1.15.2 to 1.15.4 in /previewers/react-source/hdf5-previewer
…rs/react-source/hdf5-previewer/vite-3.2.8

Bump vite from 3.2.7 to 3.2.8 in /previewers/react-source/hdf5-previewer
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.8 to 3.2.10.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v3.2.10/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v3.2.10/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Initial implementation of a X3D previewer with the X_ITE library
reduces max video width to match iframe width
dependabot bot and others added 21 commits June 21, 2024 21:31
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…rs/react-source/hdf5-previewer/braces-3.0.3

Bump braces from 3.0.2 to 3.0.3 in /previewers/react-source/hdf5-previewer
remove polyfill.io from HDF5 Preview
For pre-Dataverse 6.4 (which doesn't recognize the *.glb files, one can
edit the Accept header in the voyager-explorer.min.js script to accept *
in addition to text/plain (there is only one place this happens in their
current script so easy to find). 6.4, in addition to adding the
mimetype, changes the file download api to @produce */* (making
text/plain an OK request rather than a 406 error).
Voyager 3D support for *glb files
DD-1699: v1.4.1 max 100% for video previewer
@jo-pol jo-pol changed the title Patch 1 video Previewers for dataverse 6.5: 1.4-DANS-PATCH-1 video Feb 6, 2025
@jo-pol jo-pol marked this pull request as draft February 6, 2025 14:27
@jo-pol jo-pol changed the title Previewers for dataverse 6.5: 1.4-DANS-PATCH-1 video Previewers for dataverse: 1.4-DANS-PATCH-1 video Feb 6, 2025
@jo-pol jo-pol marked this pull request as ready for review February 6, 2025 14:42
@jo-pol jo-pol changed the title Previewers for dataverse: 1.4-DANS-PATCH-1 video DD-1698 + DD-1699: 1.4-DANS-PATCH-1 video Feb 6, 2025
@jo-pol
Copy link
Author

jo-pol commented Feb 10, 2025

replaced by #8

@jo-pol jo-pol closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants