Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1486: NullPointerException for custom dataset terms #195

Conversation

jo-pol
Copy link

@jo-pol jo-pol commented Dec 22, 2023

What this PR does / why we need it:

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@janvanmansum
Copy link

Closing this PR. The problem was present in Dataverse v5.14, but was already fixed in v6.0.

That said, the chained method call dsv.getDataset().getGlobalId().asString() is indeed still risky. It assumes that dsv, getDataset() and getGlobalId() can never return null. If this assumption is not warranted it would be a good idea have a separate method getPid. However, it should then not return no-doi-set but instead throw a more descriptive exception.

@jo-pol jo-pol deleted the DD-1486-custom-terms branch January 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants