Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed access request notifications for users with ManageFilePermissions #198

Conversation

PaulBoon
Copy link

@PaulBoon PaulBoon commented Jun 26, 2024

What this PR does / why we need it:

Which issue(s) this PR closes:

Closes #DD-1597

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build #59

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 20.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/harvard/iq/dataverse/FileDownloadServiceBean.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/harvard/iq/dataverse/dataaccess/FileAccessIO.java 2 62.82%
Totals Coverage Status
Change from base Build #57: 0.002%
Covered Lines: 17218
Relevant Lines: 83577

💛 - Coveralls

@PaulBoon PaulBoon merged commit 6657fe4 into DANS-KNAW:v6.2-DANS-DataStation Jun 28, 2024
8 checks passed
@PaulBoon PaulBoon deleted the DD-1597-FixAccessRequestNotifications branch June 28, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants