Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

DD-1627 Implemented code to term mapping for ABR artifacts #136

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

janvanmansum
Copy link
Contributor

@janvanmansum janvanmansum commented Aug 24, 2024

Fixes DD-1627

Description of changes

ABR shortcodes are now mapped to corresponding term URI.

Notify

@DANS-KNAW/core-systems

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes missing coverage. Please review.

Project coverage is 53.45%. Comparing base (0973953) to head (8394644).
Report is 8 commits behind head on master.

Files Patch % Lines
.../core/service/DepositIngestTaskFactoryBuilder.java 0.00% 5 Missing ⚠️
...a/nl/knaw/dans/ingest/config/IngestFlowConfig.java 81.81% 2 Missing ⚠️
.../dans/ingest/core/service/mapper/mapping/Base.java 83.33% 1 Missing and 1 partial ⚠️
...rvice/mapper/DepositToDvDatasetMetadataMapper.java 92.30% 0 Missing and 1 partial ⚠️
...apper/DepositToDvDatasetMetadataMapperFactory.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
- Coverage     54.26%   53.45%   -0.81%     
+ Complexity      710      697      -13     
============================================
  Files           126      125       -1     
  Lines          3223     3167      -56     
  Branches        226      228       +2     
============================================
- Hits           1749     1693      -56     
+ Misses         1427     1423       -4     
- Partials         47       51       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janvanmansum janvanmansum marked this pull request as ready for review August 28, 2024 14:10
@janvanmansum janvanmansum requested a review from a team as a code owner August 28, 2024 14:10
@janvanmansum janvanmansum merged commit 53a48d0 into DANS-KNAW:master Aug 28, 2024
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant