Dd 1689 dd manage deposit unit tests failure and skipped

[aliassheikh]

Fixes DD-1689 dd-manage-deposit unit tests: one failure and one skipped

Description of changes

• Don´t skip the skipped unit test: should_pick_up_deleted_root()
• fix failure unit test: should_pick_up_changed_properties()

How to test

MVNCI

Related PRs

(Add links)

Notify

@DANS-KNAW/core-systems

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.74%. Comparing base (41cf471) to head (811adbe).
Report is 7 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master       #9      +/-   ##
============================================
- Coverage     35.37%   33.74%   -1.63%     
- Complexity       45       49       +4     
============================================
  Files            16       16              
  Lines           359      403      +44     
  Branches         28       35       +7     
============================================
+ Hits            127      136       +9     
- Misses          226      261      +35     
  Partials          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jo-pol]

Please also remove the no longer used

dd-manage-deposit/src/test/java/nl/knaw/dans/managedeposit/AbstractTestWithTestDir.java

Lines 34 to 41 in 254e2fd

	/**
	* Assume that a bug is not yet fixed. This allows to skip assertions while still showing the code covered by the test.
	*
	* @param message the message to display
	*/
	public void assumeNotYetFixed (String message) {
	assumeTrue(false, message);
	}

[janvanmansum]

Note: needing waits in your unit tests in order for them to pass seems a bit brittle to me. I'll approve it anyway, as waiting longer will at least not make the situation worse in this case.