Skip sudo invocation if running user is sudo #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrorbyte
force-pushed
the
no-sudo-root
branch
from
1be6f7c
to
0cd4ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one has been floating around for a while #160 and bumped into a situation with systems without sudo.
I did the simple steps of checking if the user was running as
rootin the sudo context and skipping. I do think it might be a little bit more logical to check for the user before switching between the sudo and non-sudo context, but the code changes were longer. If that's preferred I'll switch it up.This is also probably my first steps for adding support for other privesc methods (as
sudo-rsis broken right now due to the lack of-psupport).