we're using the wrong formatter! (and other formatting issues) #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafkafk
force-pushed
the
fix-formatting
branch
from
38979c1 to
d1657ba
Compare
Remove deadnix from linters, since it doesn't make sense for morph, considering we may have "dead" nix code that's actually used to deploy to hosts. Signed-off-by: Christina Sørensen <[email protected]>
We're currently using the now defunct nixpkgs-fmt, moved to nixfmt, which is the one with the actual nixfmt-rfc-style. pre-commit-checks.nix doesn't understand that nixfmt is nixfmt-rfc-style yet, so we also make a slight workaround. Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
srhb
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the formatter to
nixfmt-rfc-style, and remove deadnix.Also formats the code with the new correct formatter.
stacked on #220