Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display version information in a dialog #23

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

claudio-walser
Copy link
Contributor

Hi there, I've added the functionality, mentionend in Issue #2

Hope this is sufficient and what you had in mind.

@charliefoxtwo
Copy link
Member

I don't know that I had anything specific in mind for this feature. Could you include a screenshot of how this looks? Otherwise seems fine to me!

@claudio-walser
Copy link
Contributor Author

Sure, I took one in both color modes, accelerator shortcut working as well. What is a little ugly is the fact that you can open the dialog multiple times.
image
image

@claudio-walser
Copy link
Contributor Author

claudio-walser commented Nov 27, 2024

dialog.showMessageBoxSync would fix the multiple dialog issue, but since it does not return a promise, there is no exception handling. Not quite sure what would happen in case of an error. I'll kindly let the decision up to you ;)
https://www.electronjs.org/docs/latest/api/dialog#dialogshowmessageboxsyncwndow-options

Then on the other hand, the file open dialog opens multiple times as well 🤷

@charliefoxtwo
Copy link
Member

Heh, the file dialog issue definitely sounds like a bug thst should be fixed at some point.

@charliefoxtwo charliefoxtwo added this pull request to the merge queue Nov 28, 2024
Merged via the queue into DCS-Skunkworks:main with commit a7ba062 Nov 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants