Various small fixes (#26)

DCS-Skunkworks · Oct 15, 2023 · 0ade9bf · 0ade9bf
1 parent ec700dd
commit 0ade9bf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/src/client/DCSInsight/Communication/TCPClientHandler.cs b/src/client/DCSInsight/Communication/TCPClientHandler.cs
@@ -25,7 +25,7 @@ internal class TCPClientHandler : IDisposable, ICommandListener
         private Thread _clientThread;
         private bool _isRunning;
         private readonly string _host;
-        private string _port;
+        private readonly string _port;
         private bool _apiListReceived = false;
         private int _metaDataPollCounter;
         public bool LogJSON { get; set; }

diff --git a/src/client/DCSInsight/Misc/ResultComparator.cs b/src/client/DCSInsight/Misc/ResultComparator.cs
@@ -8,8 +8,7 @@ namespace DCSInsight.Misc
     internal class ResultComparator
     {
         private readonly DCSAPI _dcsApi;
-        private bool _resultHasChanged;
-        private object _lockObject = new();
+        private readonly object _lockObject = new();
 
         public ResultComparator(DCSAPI dcsApi)
         {
@@ -61,7 +60,6 @@ public bool SetResult(DCSAPI dcsApi)
                     if (dcsApi.Result != _dcsApi.Result)
                     {
                         _dcsApi.Result = dcsApi.Result;
-                        _resultHasChanged = true;
                         return true;
                     }
                 }
@@ -71,7 +69,6 @@ public bool SetResult(DCSAPI dcsApi)
                 Common.ShowErrorMessageBox(ex);
             }
 
-            _resultHasChanged = false;
             return false;
         }
 

diff --git a/src/client/DCSInsight/Windows/WindowRangeTest.xaml.cs b/src/client/DCSInsight/Windows/WindowRangeTest.xaml.cs
@@ -32,11 +32,11 @@ public partial class WindowRangeTest : Window, IErrorListener, IConnectionListen
         private bool _stopRunning;
         private bool _doLoop;
         private bool _showChangesOnly;
-        private static readonly AutoResetEvent AutoResetEvent1 = new AutoResetEvent(false);
+        private static readonly AutoResetEvent AutoResetEvent1 = new(false);
         private Thread _thread;
-        private int _threadLoopSleep = 50;
+        private readonly int _threadLoopSleep = 50;
         private readonly List<ResultComparator> _resultComparatorList = new();
-        private object _lockObject = new();
+        private readonly object _lockObject = new();
 
         public WindowRangeTest(List<DCSAPI> dcsAPIList)
         {
@@ -137,7 +137,6 @@ public void DataReceived(DataEventArgs args)
 
                     var hasChanged = _resultComparatorList.First(o => o.IsMatch(args.DCSApi)).SetResult(args.DCSApi);
 
-                    Debug.WriteLine($"Has Changed = {hasChanged}");
                     if (_showChangesOnly && !hasChanged)
                     {
                         AutoResetEvent1.Set();
@@ -351,8 +350,10 @@ private void BuildUI()
 
                     foreach (var dcsAPIParameterType in _dcsAPI.Parameters)
                     {
-                        var stackPanel = new StackPanel();
-                        stackPanel.Orientation = Orientation.Horizontal;
+                        var stackPanel = new StackPanel
+                        {
+                            Orientation = Orientation.Horizontal
+                        };
 
                         var label = new Label
                         {