SonarCloud suggestions

DEFRA · Dec 17, 2024 · 9aacd6e · 9aacd6e
1 parent 4d5b9ef
commit 9aacd6e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/server/admin/teams/controllers/add/add-member.js b/src/server/admin/teams/controllers/add/add-member.js
@@ -88,9 +88,7 @@ const addMemberController = {
 
       request.yar.flash(
         sessionNames.globalValidationFailures,
-        rejectedResponse.map(
-          (rejectedResponse) => rejectedResponse.reason.message
-        )
+        rejectedResponse.map((response) => response.reason.message)
       )
 
       return h.redirect('/admin/teams/' + teamId + '/add-member' + queryString)

diff --git a/src/server/teams/controllers/add/add-member.js b/src/server/teams/controllers/add/add-member.js
@@ -53,8 +53,8 @@ const addMemberController = {
     }
 
     if (!validationResult.error) {
-      const addUserToTeamPromises = userIds.map(
-        async (userId) => await addMemberToTeam(request, teamId, userId)
+      const addUserToTeamPromises = userIds.map((userId) =>
+        addMemberToTeam(request, teamId, userId)
       )
 
       const responses = await Promise.allSettled(addUserToTeamPromises)
@@ -88,9 +88,7 @@ const addMemberController = {
 
       request.yar.flash(
         sessionNames.globalValidationFailures,
-        rejectedResponse.map(
-          (rejectedResponse) => rejectedResponse.reason.message
-        )
+        rejectedResponse.map((response) => response.reason.message)
       )
 
       return h.redirect('/teams/' + teamId + '/add-member' + queryString)