494910 deploy auto complete #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been moved into the autocomplete
- Bring in the publish work - Bring in the sibiling data fetcher work - Add typeahead flag a typeahead will make calls whilst typing - Update autocomplete to only make a fetch with matching text or suggestion - Updates to tests and increase coverage
SErvices, Deployments and Running Services lists
- Pass id and text - Lower case and hyphenate headers values
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publishToandsilbilngDataFetcherwork into autocompletetypeaheads. These will fetch (debounced) as a user types. The API has regex search to support thisselects. These are selects with which you can search (handy for large amounts of data). Once a user makes an exact match the page will AJAX fetch from the API. These API endpoints support exact match only on these valuesAssociated PR
DEFRA/cdp-portal-backend#225
Demo
Screenshots